Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G gitlabhq1
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gpt
  • large_projects
  • gitlabhq1
  • Merge requests
  • !7107

Merged
Created Jun 10, 2014 by Administrator@rootOwner

Clarify that bbastov is the style of Hound CI 2.

  • Overview 2
  • Commits 2
  • Changes 1

Created by: cirosantilli

Continued from https://github.com/gitlabhq/gitlabhq/pull/6786

Added Rubocop link.

Set option B, previous line.


Since I wrote this, Hound docs improved. They say their default is:

If you break up a chain of method invocations, keep each method invocation on its own line. Place the . at the end of each line, except the last.

I don't think bbastov specifies one method per line, so in theory Hound should check more like "Option B + one method per line."

In practice however hound does not seem to enforce one method by line by default, so it ends up being the same as bbastov because of that bug.

For now we can leave Option B.

For the future I propose we use one single tool and the style that comes with it to reduce the probability of conflicts between the styles, so either:

  • Hound + hound style
  • Rubocop + bbastov style
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: github/fork/cirosantilli/clarify-hound-ci-style