GitLab

Created by: dblessing

Hi @bhuisgen. Thanks for your contribution. Although in a case statement the scoping works out in this case, it might be confusing or unclear. I had to test your code to be sure encryption was set properly after the case statement. It might be more clear if you modify the block to assign the value to encryption as seen in these examples from the Ruby style guide:

# good - it's apparent what's going on
kind = case year
       when 1850..1889 then 'Blues'
       when 1890..1909 then 'Ragtime'
       when 1910..1929 then 'New Orleans Jazz'
       when 1930..1939 then 'Swing'
       when 1940..1950 then 'Bebop'
       else 'Jazz'
       end

result = if some_cond
           calc_something
         else
           calc_something_else
         end

# good (and a bit more width efficient)
kind =
  case year
  when 1850..1889 then 'Blues'
  when 1890..1909 then 'Ragtime'
  when 1910..1929 then 'New Orleans Jazz'
  when 1930..1939 then 'Swing'
  when 1940..1950 then 'Bebop'
  else 'Jazz'
  end

result =
  if some_cond
    calc_something
  else
    calc_something_else
  end

If you make the change as suggested and squash the commits, I'll mark this as ready for merge. Thanks again!

By Administrator on 2014-06-18T21:42:13 (imported from GitLab project)

Created by: bhuisgen

@dblessing it's done.

By Administrator on 2014-06-19T08:49:27 (imported from GitLab project)

Created by: dblessing

The travis failure appears to be unrelated - only failed on spec:feature with

1) On a merge request when posting a note should be added and form reset
     Failure/Error: Unable to find matching line from backtrace
     EOFError:
       end of file reached
     # ./app/helpers/application_helper.rb:156:in `image_url'
     # ./app/controllers/projects_controller.rb:136:in `block in autocomplete_sources'
     # ./app/controllers/projects_controller.rb:136:in `map'
     # ./app/controllers/projects_controller.rb:136:in `autocomplete_sources'

By Administrator on 2014-07-08T01:14:20 (imported from GitLab project)

Created by: dblessing

Ready for merge

By Administrator on 2014-07-08T01:14:26 (imported from GitLab project)

Fix LDAP TLS authentication