Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G gitlabhq1
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gpt
  • large_projects
  • gitlabhq1
  • Merge requests
  • !7225

Closed
Created Jun 28, 2014 by Administrator@rootOwner
  • Report abuse
Report abuse

Refine Spec Project#last_activity_date

  • Overview 8
  • Commits 4
  • Changes 1

Created by: jhund

What does this MR do?

It fixes two issues with the spec for Project#last_activity_date:

  • make timing requirement less stringent so that it doesn't fail on slow systems like Travis CI
  • fix logical error, replace project.last_activity_at with project.last_activity_date since this is what's being tested in this spec.

For more details please see #7223 (closed)

Why was this MR needed?

Because Travis CI builds fail unnecessarily and the test has a logical error that renders the test useless.

What are the relevant issue numbers / Feature requests?

Fixes #7223 (closed)

/cc @jvanbaarsen

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: github/fork/jhund/fix-7223