Skip to content

GitLab

  • Menu
    • Projects Groups Snippets
      Help
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G gitlabhq1
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gpt
  • large_projects
  • gitlabhq1
  • Merge requests
  • !7318

Merged
Created 10 years ago by Administrator@rootOwner

Removed some constant allready defined warnings

  • Overview 4
  • Commits 1
  • Changes 2

Created by: jvanbaarsen

What does this MR do? It makes sure that warnings of already defined constants are not shown anymore

Why is this MR needed? Its a little annoying that you see constant warnings every time you run a command

The warnings it removes:

/Users/jeroen/Development/gitlabhq/lib/gitlab/theme.rb:3: warning: already initialized constant Gitlab::Theme::BASIC
/Users/jeroen/Development/gitlabhq/lib/gitlab/theme.rb:3: warning: previous definition of BASIC was here
/Users/jeroen/Development/gitlabhq/lib/gitlab/theme.rb:4: warning: already initialized constant Gitlab::Theme::MARS
/Users/jeroen/Development/gitlabhq/lib/gitlab/theme.rb:4: warning: previous definition of MARS was here
/Users/jeroen/Development/gitlabhq/lib/gitlab/theme.rb:5: warning: already initialized constant Gitlab::Theme::MODERN
/Users/jeroen/Development/gitlabhq/lib/gitlab/theme.rb:5: warning: previous definition of MODERN was here
/Users/jeroen/Development/gitlabhq/lib/gitlab/theme.rb:6: warning: already initialized constant Gitlab::Theme::GRAY
/Users/jeroen/Development/gitlabhq/lib/gitlab/theme.rb:6: warning: previous definition of GRAY was here
/Users/jeroen/Development/gitlabhq/lib/gitlab/theme.rb:7: warning: already initialized constant Gitlab::Theme::COLOR
/Users/jeroen/Development/gitlabhq/lib/gitlab/theme.rb:7: warning: previous definition of COLOR was here
/Users/jeroen/Development/gitlabhq/lib/gitlab/visibility_level.rb:8: warning: already initialized constant Gitlab::VisibilityLevel::PRIVATE
/Users/jeroen/Development/gitlabhq/lib/gitlab/visibility_level.rb:8: warning: previous definition of PRIVATE was here
/Users/jeroen/Development/gitlabhq/lib/gitlab/visibility_level.rb:9: warning: already initialized constant Gitlab::VisibilityLevel::INTERNAL
/Users/jeroen/Development/gitlabhq/lib/gitlab/visibility_level.rb:9: warning: previous definition of INTERNAL was here
/Users/jeroen/Development/gitlabhq/lib/gitlab/visibility_level.rb:10: warning: already initialized constant Gitlab::VisibilityLevel::PUBLIC
/Users/jeroen/Development/gitlabhq/lib/gitlab/visibility_level.rb:10: warning: previous definition of PUBLIC was here
  • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
Please register or sign in to reply
Compare
  • master (base)

and
  • latest version
    3c439888
    1 commit, 5 years ago

There are merge conflicts

The comparison view may be inaccurate due to merge conflicts.

Resolve these conflicts or ask someone with write access to this repository to merge it locally.

0 Assignees
Assign to
0 Reviewers
Request review from
Milestone
No milestone
None
None
Time tracking
1
Labels
Ready for Merge
Assign labels
  • No matching results
  • Manage project labels
Lock merge request
Unlocked
participants
Reference:
Source branch: github/fork/jvanbaarsen/constant-warning-fix

    0 pending comments

Menu

Projects Groups Snippets
Help