Skip to content

GitLab

  • Menu
    • Projects Groups Snippets
      Help
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G gitlabhq1
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gpt
  • large_projects
  • gitlabhq1
  • Merge requests
  • !7345

Closed
Created 10 years ago by Administrator@rootOwner
  • Report abuse
Report abuse

[WIP] Resolve MR conflicts from web interface.

  • Overview 75
  • Commits 7
  • Changes 20

Created by: cirosantilli

Fixes AMR http://feedback.gitlab.com/forums/176466-general/suggestions/5590496-resolve-any-merge-request-conflict-from-the-web-in

When there are conflicts it shows:

screenshot from 2014-07-21 17 02 05 gitlab resolve here

Then under the conflicts URL, there is an AJAX tab like "Changes":

screenshot from 2014-07-21 17 23 40 gitlab resolve conflicts tab

When done, user clicks on the "Resolve conflicts and merge pull request" button at the bottom to finish.

Detail of one of the conflicts:

screenshot from 2014-07-21 17 26 13 gitlab resolve detail

For each conflict, user must select one of 4 radio boxes: ours, base, theirs, or custom.

ours, base and theirs will contain fixed values parsed directly from git checkout --conflict=diff3. Bytes that changed between ours and base and theirs and base are highlighted like in the diffs with idiff spans by Diffy.

custom will use the value of the textarea for a custom resolution. Its value defaults to ours which is a reasonable starting point for custom edits.

It is currently not possible to modify parts of the text outside of the conflict: one web UI workaround would be to leave them there, choose ours, merge the MR and only then those points by editing.

Tell me if the concept is OK so I can proceed do the backend.

Loading
Loading

  • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Milestone
No milestone
None
None
Time tracking
1
Labels
Awaiting developer action/feedback
Assign labels
  • No matching results
  • Manage project labels
Lock merge request
Unlocked
participants
Reference:
Source branch: github/fork/cirosantilli/resolve

    0 pending comments

Menu

Projects Groups Snippets
Help