Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G gitlabhq1
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gpt
  • large_projects
  • gitlabhq1
  • Merge requests
  • !7385

Merged
Created Jul 27, 2014 by Administrator@rootOwner2 of 2 tasks completed2/2 tasks

Fix 500 on searching on empty project, restyle search page

  • Overview 23
  • Commits 2
  • Changes 7

Created by: Razer6

What does this MR do?

This PR fixes searching on empty projects and adds a testcase therefore. For this reason, an empty search result displays a notification message as shown below. Since this is needed for the testcase, I also do restyling of the page here.

Why was this MR needed?

Currently searching on an empty project raises a 500 error.

What are the relevant issue numbers / Feature requests?

This PR fixes

  • #7217 (closed)
  • #6776 (closed)
  • https://gitlab.com/gitlab-org/gitlab-ce/issues/119

TODO

  • Better styling if there is no search result
  • Extend notice message if there is no search result to issues

Screenshots

Before

screenshot 2014-07-31 00 09 46

After

screenshot 2014-07-31 00 05 56 screenshot 2014-07-31 00 06 44

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: github/fork/Razer6/fix_search_empty_project