Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G gitlabhq1
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gpt
  • large_projects
  • gitlabhq1
  • Merge requests
  • !7617

Merged
Created Aug 27, 2014 by Administrator@rootOwner

Issue-280 Send notifications when a note is added to a commit and author...

  • Overview 19
  • Commits 1
  • Changes 1

Created by: pkill

... is a group member

This fixes a bug where commit authors weren't receiving email notifications for notes added to their commits and their membership was in the group but not the project. The fix is to look up membership from the group in addition to the lookup that was being performed for the project.

I do plan on writing rspec tests for this but I wanted to get this MR submitted without the test so that it receives visibility since I've been sitting on this fix for a while. I'd like for this to make it into 7.3.

This is a fix for Issue-280 and the duplicate Issue-530. https://gitlab.com/gitlab-org/gitlab-ce/issues/280 https://gitlab.com/gitlab-org/gitlab-ce/issues/530

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: github/fork/pkill/issue-280-commit-note-notifications