Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G gitlabhq1
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gpt
  • large_projects
  • gitlabhq1
  • Merge requests
  • !7658

Merged
Created 10 years ago by Administrator@rootOwner

Show labels help message if last label is deleted

  • Overview 7
  • Commits 1
  • Changes 5

Created by: Razer6

What does this PR do?

If the last label is deleted, the label information message is shown again

Why is this needed?

Currently, if the last label is delated, an empty white page is shown. UX is better, to show instructions for labels again.

Related issues

This is related to #7522 which implements the same for tags.

Loading
Loading

  • Administrator
    Administrator @root · 10 years ago
    Owner

    Created by: TeatroIO

    I've prepared a stage. Click to open.

    By Administrator on 2014-09-01T08:56:52 (imported from GitLab project)

  • Administrator
    Administrator @root · 10 years ago
    Owner

    Created by: Razer6

    @randx It's strange. Locally, it passes all tests. Do you might have an idea?

    By Administrator on 2014-09-02T07:17:26 (imported from GitLab project)

  • Administrator
    Administrator @root · 10 years ago
    Owner

    Created by: Razer6

    @randx Should be fixed now.

    By Administrator on 2014-09-03T11:14:38 (imported from GitLab project)

  • Administrator
    Administrator @root started a thread on commit bd235519 10 years ago
    app/views/projects/labels/destroy.js.haml
    1 if @project.labels.size == 0
    • Administrator
      Administrator @root · 10 years ago
      Owner

      Created by: dzaporozhets

      are you reloading page after each label remove action?

      By Administrator on 2014-09-04T21:15:45 (imported from GitLab project)

  • Administrator
    Administrator @root · 10 years ago
    Owner

    Created by: Razer6

    only the tags div. If it was the last one, the info message is shown.

    By Administrator on 2014-09-04T12:55:59 (imported from GitLab project)

  • Administrator
    Administrator @root · 10 years ago
    Owner

    Created by: Razer6

    @randx I've updated the PR to only load the div, if the last label is delated. I've implemented #7522 the same

    By Administrator on 2014-09-04T21:43:38 (imported from GitLab project)

  • Administrator
    Administrator @root · 10 years ago
    Owner

    Created by: dzaporozhets

    ok thanks

    By Administrator on 2014-09-05T11:39:44 (imported from GitLab project)

  • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
Please register or sign in to reply
0 Assignees
Assign to
0 Reviewers
Request review from
Milestone
No milestone
None
None
Time tracking
1
Labels
UI
Assign labels
  • No matching results
  • Manage project labels
Lock merge request
Unlocked
participants
Reference:
Source branch: github/fork/Razer6/refresh_labels_page_on_delete

    0 pending comments