Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G gitlabhq1
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gpt
  • large_projects
  • gitlabhq1
  • Merge requests
  • !7678

Merged
Created Sep 03, 2014 by Administrator@rootOwner

Factor new issue and edit MR forms.

  • Overview 7
  • Commits 1
  • Changes 3

Created by: cirosantilli

There was a lot of code duplication here.

There is also a third copy which has diverged more and which we should DRY out as well: the new MR form. It probably has the best visual style of the three and should be the one to copy. Opened an issue for that at: https://github.com/gitlabhq/gitlabhq/issues/7679 so we won't forget.

The issue edit and new were already factored.

Minor visible changes:

  • "Issue is parsed with GFM" message changed to: "Parsed with GFM". Shorter, DRYer, and it is obvious that we are talking about the description that corresponds to the textarea above.

I cannot see any other behavior / UI changes.

Non-visible changes:

  • title input element:
    • remove rows attribute. Does nothing on input type="text".
    • remove class "pad" from the merge request form. Not used anywhere in the app.

TODO in future merge requests: DRY those forms even further on the points they diverged more:

  • errors
  • labels
  • submit

Found using https://github.com/UncleGene/flay-haml

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: github/fork/cirosantilli/factor-new-issue-edit-mr