Skip to content

GitLab

  • Menu
    • Projects Groups Snippets
      Help
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G gitlabhq1
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gpt
  • large_projects
  • gitlabhq1
  • Merge requests
  • !7905

Merged
Created 10 years ago by Administrator@rootOwner

Change always passing visible false tests.

  • Overview 10
  • Commits 1
  • Changes 4

Created by: cirosantilli

Many usages of visible: false are wrong since visible: false matches both visible and invisible elements: http://rubydoc.info/github/jnicklas/capybara/master/Capybara/Node/Finders#all-instance_method

The correct way to check that an element is present but not visible is:

expect(find(...)).not_to be_visible

The two "I can't preview without text" scenarios are not true anymore: now you can preview without text, so I removed then. They only passed because of the misuse. Screenshot:

screenshot from 2014-09-30 15 56 00 js not preview visible without text

'I should see add a diff comment button' is simply wrong: it should be visible: true instead of visible: false.

  • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
Please register or sign in to reply
  1. 01 Jan, 2015 1 commit
    • Ciro Santilli's avatar
      Change always passing visible true tests to false. · 67b06e7a
      Ciro Santilli authored 10 years ago
      67b06e7a
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Milestone
7.8
7.8 (expired)
None
Time tracking
No estimate or time spent
1
Labels
Ready for Merge
Assign labels
  • No matching results
  • Manage project labels
Lock merge request
Unlocked
1
1 participant
user avatar
Reference: gpt/large_projects/gitlabhq1!7905
Source branch: github/fork/cirosantilli/visible-false

    0 pending comments

Menu

Projects Groups Snippets
Help