Skip to content

GitLab

  • Menu
    • Projects Groups Snippets
      Help
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G gitlabhq1
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gpt
  • large_projects
  • gitlabhq1
  • Merge requests
  • !7925

Merged
Created 10 years ago by Administrator@rootOwner

Remove or prepend underscore _ to unused method arguments

  • Overview 6
  • Commits 1
  • Changes 3

Created by: cirosantilli

  • remove up_dir_path tree which can be removed
  • add underscore Devise callbacks to silence Hound in those cases where it cannot be omitted as mentioned at: https://github.com/gitlabhq/gitlabhq/pull/7858#discussion-diff-18063612
Request to merge github/fork/cirosantilli/unused-arguments into master
  • Download as
  • Email patches

  • Plain diff

Checking approval status

Merged by (Jun 20, 2025 4:09pm UTC)

The changes were merged into master with 6c65b91d

The source branch has been deleted


  • Administrator
    Administrator @root · 10 years ago
    Owner

    Created by: TeatroIO

    I've prepared a stage. Click to open.

    By Administrator on 2014-09-30T20:32:49 (imported from GitLab project)

  • Administrator
    Administrator @root started a thread on commit 6c65b91d 10 years ago
    app/controllers/registrations_controller.rb
    15 15 super
    16 16 end
    17 17
    18 def after_sign_up_path_for(resource)
    18 def after_sign_up_path_for(_resource)
    19 19 new_user_session_path
    20 20 end
    21 21
    22 def after_inactive_sign_up_path_for(resource)
    22 def after_inactive_sign_up_path_for(_resource)
    • Administrator
      Administrator @root · 10 years ago
      Owner

      Created by: houndci-bot

      Use def with parentheses when there are parameters.

      By Administrator on 2014-12-27T21:38:43 (imported from GitLab project)

  • Administrator
    Administrator @root started a thread on commit 6c65b91d 10 years ago
    app/controllers/registrations_controller.rb
    15 15 super
    16 16 end
    17 17
    18 def after_sign_up_path_for(resource)
    18 def after_sign_up_path_for(_resource)
    • Administrator
      Administrator @root · 10 years ago
      Owner

      Created by: houndci-bot

      Use def with parentheses when there are parameters.

      By Administrator on 2014-12-27T21:38:43 (imported from GitLab project)

  • Administrator
    Administrator @root · 10 years ago
    Owner

    Created by: jvanbaarsen

    @cirosantilli Can you please make this mergeable again?

    By Administrator on 2014-12-13T19:47:23 (imported from GitLab project)

  • Administrator
    Administrator @root · 10 years ago
    Owner

    Created by: cirosantilli

    Updated.

    By Administrator on 2014-12-27T21:39:17 (imported from GitLab project)

  • Administrator
    Administrator @root · 10 years ago
    Owner

    Created by: dzaporozhets

    Thanks

    By Administrator on 2015-01-15T22:42:12 (imported from GitLab project)

  • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Milestone
7.8
7.8 (expired)
None
Time tracking
No estimate or time spent
1
Labels
Ready for Merge
Assign labels
  • No matching results
  • Manage project labels
Lock merge request
Unlocked
1
1 participant
user avatar
Reference: gpt/large_projects/gitlabhq1!7925
Source branch: github/fork/cirosantilli/unused-arguments

    0 pending comments

Menu

Projects Groups Snippets
Help