Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G gitlabhq1
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gpt
  • large_projects
  • gitlabhq1
  • Merge requests
  • !7937

Closed
Created Oct 02, 2014 by Administrator@rootOwner
  • Report abuse
Report abuse

[WIP] Make issue assigned filters more uniform across group and project [Can be updated]

  • Overview 23
  • Commits 1
  • Changes 10

Created by: cirosantilli

This PR makes the Assigned to me / created by me / everyone's issue filter more uniform between project, dashboard and group issues.

The only UI change is that for the dashboard and group, the order changed from:

  • assigned to me
  • created by me
  • everyone's

to:

  • everyone's
  • assigned to me
  • created by me

which matches the order under projects. Those two should have the same order: it makes the UI more uniform.

Note that the default values for those attributes is different between views and has not been changed: for dashboard it is assigned to me, for groups depends on signed in or not, and for project issues it is always everyone's.

The greater uniformity also allowed a large factorization.

screenshot from 2014-10-02 11 11 14 factor filter state assigned

Implementation notes:

  • removed the .scope-filter class which is not used anywhere
  • removed the unused entity argument to facilitate polymorphism
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: github/fork/cirosantilli/factor-filter-views