Improve file icons rendering on tree
Created by: soullivaneuh
TODO list:
- Make decision about icons choose and methods
- Integrate new icons to tree index view
- Integrate new icons to tree file show view
- Write some test about the different icon rendering
- Update CHANGELOG
Referred to this request, I did some improvements to file icons rendering.
This mean:
- Use fa-fw (fixed width) class for homogeneous column sizes
- fa-file-text-o for regular files.
- fa-share icon for links.
- fa-file-code-o icon for executable files.
So, from the actual design:
I made this:
The share link sounds good for me, but I don't really like the file-code for binary, to tiny to differentiate and note really appropriate...
So I tried with fa-terminal:
Well, not really better. So what about fa-cog ?
In my opinion, I think fa-cog is the better rendering for binaries. But, well, doesn't really look like a file...
Two possible options:
- Use fa-stack method for custom file icon as explained here, but I have to change the template code for this and this will force you to use file-icon in any way.
- Integrate Github octicons which has binary and symlink icons.
If we choose the second option, I have to check before if Octicons and Font Awesome libraries can work together without any conflict. Furthermore, I think we will have to add some contributing rules indicate that the FA icons must be user in priority!
I need your feedback to continue this work. If you have another ideas/solutions, please tell me more!
Waiting yours reviews.