Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G gitlabhq1
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gpt
  • large_projects
  • gitlabhq1
  • Merge requests
  • !7990

Closed
Created Oct 07, 2014 by Administrator@rootOwner
  • Report abuse
Report abuse

Remove unnecessary service requires [passes locally, always fails on CI]

  • Overview 6
  • Commits 1
  • Changes 6

Created by: cirosantilli

and explicit modules MergeRequests::

Rails does magic autoloading based on file paths and we already use it extensively.

I don't understand why but this always passes locally and always fails on CI because of the new edit and remove blob actions.

From the errors it is clear that the file services are loading the wrong base service (base instead of file/base) on the CI because of the wrong number of arguments.

I don't understand why this is so: according to this blog post http://urbanautomaton.com/blog/2013/08/27/rails-autoloading-hell/ Files::BaseService should be searched first.

As it stands it cannot be merged because it would break the CI, but I'd really like to know why it fails only on the CI and not locally...

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: github/fork/cirosantilli/rm-service-require