Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G gitlabhq1
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gpt
  • large_projects
  • gitlabhq1
  • Merge requests
  • !8127

Merged
Created Oct 21, 2014 by Administrator@rootOwner

Run user select Js only where needed

  • Overview 5
  • Commits 1
  • Changes 3

Created by: cirosantilli

Transform current implementation into regular Coffescript classes so that the same call method can be reused on the dispatcher as for other classes.

Same rationale as: https://github.com/gitlabhq/gitlabhq/pull/8123

I have built the map by grepping for the touched classes + testing it out.

Double check

That I didn't make any mistakes when converting the existing coffee into classes.

The only changes are:

  • formatResult and formatSelection became instance methods. For this to work, callbacks that use them need to bind with => instead of -> ( to avoid repeating class names by using the binded this)
  • removed the prefix from instance methods, e.g. userFormatSelection became just formatSelection since it is already inside the UserSelect class
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: github/fork/cirosantilli/user-select-js-only-needed