Skip to content

GitLab

Closed
Created by Administrator@rootOwner
Report abuse

Stop blacklisting project path

Created by: cirosantilli

Before this PR, all project paths at: https://github.com/gitlabhq/gitlabhq/blob/199029b842de7c9d52b5c95bdc1cc897da8e5560/lib/gitlab/blacklist.rb were forbidden.

This PR removes that restriction, keeping it only for namespaces where it is required.

The restriction is not necessary and just creates more exception cases that can annoy users.

The blacklist was used here because of the fear of conflicting an URLs like /groupname/issues for two possible uses:

  1. all issues of the group
  2. a project called issues

however case 1 is impossible since:

  • all group URLs are prefixed by /group (e.g. /group/groupname/issues), except the base /groupname which redirects to /group/groupname

  • currently URLs like /groupname/issues don't redirect to /group/groupname/issues and give 404 instead.

    This is sane and should not be undone in the future, or else we would have problems whenever we want to add a new path to the blacklist.

This is also the URL strategy used by GitHub.