Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G gitlabhq1
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gpt
  • large_projects
  • gitlabhq1
  • Merge requests
  • !8231

Merged
Created Nov 03, 2014 by Administrator@rootOwner

Fix push not allowed to protected branch if commit starts with 7 zeros.

  • Overview 3
  • Commits 1
  • Changes 3

Created by: cirosantilli

Fix https://github.com/gitlabhq/gitlabhq/issues/8232

This fix works because the function is only called by the internal API, which gets refs from git pre-receive-hook from gitlab shell, which always sends full SHA-1s to the stdin.

There are many other such similar problems on the APP where short 0 strings are tested for: there is even a '0' * 5, which exists in the gitlab repo: only 40 zeroes should be used everywhere: this SHA1 has not been inversed so far and would break Git: http://stackoverflow.com/questions/1902340/can-a-sha-1-hash-be-all-zeroes

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: github/fork/cirosantilli/0000