Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G gitlabhq1
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gpt
  • large_projects
  • gitlabhq1
  • Merge requests
  • !8670

Merged
Created Jan 28, 2015 by Administrator@rootOwner

Add icon helper method

  • Overview 4
  • Commits 3
  • Changes 9

Created by: rspeicher

This adds an icon helper method to the IconsHelper module (and also moves the spinner helper method there to make ApplicationHelper less of a junk drawer). Right now this method simply delegates to fa_icon built into the font-awesome-rails gem. It handles creating the i element and adds the necessary classes.

This cleans up some minor pieces of code. If this PR gets accepted I've got another one that updates all of the HAML views to use this as well (e.g., %i.fa.fa-code-fork becomes = icon('code-fork')), but I didn't include it in this one because its touches dozens of files and I want to minimize the merge conflicts.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: github/fork/rspeicher/rs-fa-icon-helper