Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G gitlabhq1
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gpt
  • large_projects
  • gitlabhq1
  • Merge requests
  • !8936

Closed
Created Mar 09, 2015 by Administrator@rootOwner
  • Report abuse
Report abuse

Fix invalid GitHub `authorize_url`.

  • Overview 10
  • Commits 1
  • Changes 3

Created by: ykzts

$ ./bin/rspec ./spec/lib/gitlab/github_import/client_spec.rb
F

Failures:

  1) Gitlab::GithubImport::Client #authorize_url
     Failure/Error: expect(client.authorize_url("https://app.com")).to eq(authorize_url)

       expected: "https://github.com/login/oauth/authorize?response_type=code&client_id=YOUR_APP_ID&redirect_uri=https%3A%2F%2Fapp.com&scope=repo%2C+user%2C+user%3Aemail"
            got: "https://api.github.com/oauth/authorize?response_type=code&client_id=YOUR_APP_ID&redirect_uri=https%3A%2F%2Fapp.com&scope=repo%2C+user%2C+user%3Aemail"

       (compared using ==)
     # ./spec/lib/gitlab/github_import/client_spec.rb:12:in `block (2 levels) in <top (required)>'
     # -e:1:in `<main>'

Finished in 5.87 seconds
1 example, 1 failure

Failed examples:

rspec ./spec/lib/gitlab/github_import/client_spec.rb:4 # Gitlab::GithubImport::Client test
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: github/fork/ykzts/fix-github-authorize_url