Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G gitlabhq1
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gpt
  • large_projects
  • gitlabhq1
  • Merge requests
  • !9104

Merged
Created Apr 08, 2015 by Administrator@rootOwner

Fix issue9098 clean path

  • Overview 0
  • Commits 3
  • Changes 1

Created by: jdsn

Namespace.clean_path removed the last character from generated usernames. This is fixed along with two other changes to drop all trailing dots and all leading dashes (which is what the code most likely should have done).

Due to the ordering of the gsub statements the test in spec/models/namespace_spec.rb:93 was successful, but only because the filtering for valid characters was done after dropping the last character.

Fixes: https://github.com/gitlabhq/gitlabhq/issues/9098

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: github/fork/jdsn/fix-issue9098-clean_path