Skip to content

GitLab

  • Menu
    • Projects Groups Snippets
      Help
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G gitlabhq1
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gpt
  • large_projects
  • gitlabhq1
  • Merge requests
  • !942

Merged
Created 13 years ago by Administrator@rootOwner

Network graph fix (#909)

  • Overview 8
  • Commits 5
  • Changes 2

Created by: veprbl

Fixes #909 (closed). to be short: this patch turns this http://rghost.net/38755422/image.png into this http://rghost.net/38755441/image.png

In the ruby part it is just a new algorithm which properly places branches. I'm not a big ruby programmer, so this code may require some style fixing.

Javascript part replaces original lines placing with more practical github-like. This part may require some aesthetic revision.

All in all this patch still makes a good boost for gitlab's network graph usability.

Request to merge github/fork/veprbl/network_graph_fix into master
  • Download as
  • Email patches

  • Plain diff

Checking approval status

Merged by (Jun 20, 2025 5:43am UTC)

The changes were merged into master with 16339579

The source branch has been deleted

Mentions #909 (closed)


  • Administrator
    Administrator @root · 13 years ago
    Owner

    Created by: vsizov

    In the images i see that you have changed only design. What does your algorithm do?

    By Administrator on 2012-06-19T14:04:19 (imported from GitLab project)

  • Administrator
    Administrator @root · 13 years ago
    Owner

    Created by: dzaporozhets

    @veprbl much better now. Thank you!

    By Administrator on 2012-06-19T14:05:14 (imported from GitLab project)

  • Administrator
    Administrator @root · 13 years ago
    Owner

    Created by: veprbl

    I haven't changed it much since my post in #909 (closed).

    The whole idea is to set "space" (which is later converted to y coord) value properly. Original algorithm didn't take into account space values of other branchings, thus failed to determine right space value.

    See the difference: http://tau.rghost.ru/38598991/image.png http://tau.rghost.ru/38598999/image.png

    After that JavaScript comes into play and tweaks the rest.

    By Administrator on 2012-06-19T14:21:48 (imported from GitLab project)

  • Administrator
    Administrator @root · 13 years ago
    Owner

    Created by: veprbl

    @randx you're welcome!

    By Administrator on 2012-06-19T14:26:46 (imported from GitLab project)

  • Administrator
    Administrator @root · 13 years ago
    Owner

    Created by: vsizov

    https://github.com/gitlabhq/gitlabhq/issues/957

    By Administrator on 2012-06-22T07:34:37 (imported from GitLab project)

  • Administrator
    Administrator @root · 13 years ago
    Owner

    Created by: dzaporozhets

    @veprbl can you review #957 (closed)? If its connected with your PR it will be great you fix it in 1-2 days

    By Administrator on 2012-06-22T07:53:28 (imported from GitLab project)

  • Administrator
    Administrator @root · 13 years ago
    Owner

    Created by: dzaporozhets

    @veprbl Sorry - seems like its cause of #867 PR

    By Administrator on 2012-06-22T08:38:02 (imported from GitLab project)

  • Administrator
    Administrator @root · 13 years ago
    Owner

    Created by: veprbl

    @randx Yes I saw this problem before and confirm that this was broken long before my PR. I also found one simular problem: #941 (closed)

    By Administrator on 2012-06-22T09:12:01 (imported from GitLab project)

  • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Milestone
2.6
2.6 (expired)
None
Time tracking
No estimate or time spent
0
Labels
None
Assign labels
  • No matching results
  • Manage project labels
Lock merge request
Unlocked
1
1 participant
user avatar
Reference: gpt/large_projects/gitlabhq1!942
Source branch: github/fork/veprbl/network_graph_fix

    0 pending comments

Menu

Projects Groups Snippets
Help