Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G gitlabhq1
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gpt
  • large_projects
  • gitlabhq1
  • Merge requests
  • !951

Merged
Created Jun 20, 2012 by Administrator@rootOwner

Replace calls to deprecated link_to_function with doc-ready functions.

  • Overview 13
  • Commits 3
  • Changes 5

Created by: robbkidd

Rails 3.2.4 deprecated the link_to_function helper method. rails/rails@9dc57fe9c

It appears there are no tests for the original link_to_function behaviors. I tested these changed manually by running a GitLab instance in development mode, adding a project for the current GitLabHQ code base and creating a merge request with a branch with more than 8 commits.

However, I found it difficult to create the correct state in a view spec or request spec to test the old and new code. Any ideas where and how I could add tests for this? Maybe in the new cucumber tests? I believe it is a matter of having the test gitlab repo--tmp/tests/gitlabhq--have some branches and commits in the expected states. Does that seem right?

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: github/fork/robbkidd/remove_link_to_function