Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G gitlabhq1
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gpt
  • large_projects
  • gitlabhq1
  • Merge requests
  • !9684

Merged
Created 9 years ago by Administrator@rootOwner

Fix link with emoji

  • Overview 2
  • Commits 1
  • Changes 2

Created by: ysakasin

Fix issue: https://github.com/gitlabhq/gitlabhq/issues/9413 https://gitlab.com/gitlab-org/gitlab-ce/issues/2349

When exec link_to_gfm(':book:Book', '/foo'), The value of gfm_body is:

<img class="emoji" title=":book:" alt=":book:" src="path/to/emoji.png" height="20" width="20" align="absmiddle">Book

The result of Nokogiri::XML::DocumentFragment.parse(gfm_body) is:

<img class="emoji" title=":book:" alt=":book:" src="path/to/emoji.png" height="20" width="20" align="absmiddle">Book</img>

because the img tag has not an end tag and it is not XML. So Nokogiri::HTML::DocumentFragment.parse(gfm_body) is returned the expected value which is img tag and Book.

  • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
Please register or sign in to reply
0 Assignees
Assign to
0 Reviewers
Request review from
Milestone
No milestone
None
None
Time tracking
0
Labels
None
Assign labels
  • No matching results
  • Manage project labels
Lock merge request
Unlocked
participants
Reference:
Source branch: github/fork/ysakasin/master

    0 pending comments