Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G gitlabhq1
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gpt
  • large_projects
  • gitlabhq1
  • Merge requests
  • !9749

Merged
Created Oct 19, 2015 by Administrator@rootOwner

Fix regex in redis version check

  • Overview 0
  • Commits 1
  • Changes 1

Created by: Bufallo

When i am executing "sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production" i run into an error on the redis version check:

Redis version >= 2.4.0? ... rake aborted! ArgumentError: Malformed version number string 2.8.19 (git:0a21368c-dirty) /home/git/gitlab/lib/tasks/gitlab/check.rake:340:in check_redis_version' /home/git/gitlab/lib/tasks/gitlab/check.rake:30:inblock (3 levels) in <top (required)>' Tasks: TOP => gitlab:check => gitlab:app:check (See full trace by running task with --trace)

On my Debian 7.9 i get the following result when executing "redis-cli --version": redis-cli 2.8.19 (git:0a21368c-dirty)

The current regex to extract the version number (.*) fails to extract a valid version number in my use case. So this pull request provides a updated regex to only extract a valid version number.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: github/fork/Bufallo/fix-redis-check