Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G gitlabhq1
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gpt
  • large_projects
  • gitlabhq1
  • Merge requests
  • !9938

Merged
Created Dec 30, 2015 by Administrator@rootOwner

Hotfix note mail with notification

  • Overview 0
  • Commits 2
  • Changes 2

Created by: huacnlee

Today I found some error log:

Email can not be processed: undefined method `note_note_email' for Notify:Class

When I reply a Issue comment by Email reply, It will create a new Note into database but not relation with the Issue.


In current 8-3-stable (even in master version), Emails::Notes invoked SentNotification.record, that will store a bad noteable value.

See this file: https://github.com/gitlabhq/gitlabhq/blob/8-0-stable/app/mailers/emails/notes.rb#L46

@YorickPeterse

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: github/fork/huacnlee/hotfix/note_mail_with_notification